chore: migrate to latest sass-embedded#31177
Merged
VasilyStrelyaev merged 5 commits intoJan 8, 2026
Merged
Conversation
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
2 times, most recently
from
39fdebf to
ebfacaa
Compare
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
from
42cd403 to
6959bdc
Compare
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
2 times, most recently
from
43e9fab to
90ca469
Compare
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
from
0531103 to
4f46c0b
Compare
alexslavr
force-pushed
the
bump-sass-embedded
branch
3 times, most recently
from
613db2f to
19310d5
Compare
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
2 times, most recently
from
0e188bb to
108a90c
Compare
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
2 times, most recently
from
4b21a3c to
700f290
Compare
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
from
700f290 to
8d54922
Compare
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
2 times, most recently
from
57c2daa to
9b70036
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the DevExtreme monorepo to sass-embedded 1.97.1, updating from version 1.59.2/1.66.0. The migration addresses breaking changes in Sass, primarily deprecations of legacy color manipulation functions and the transition to modern Sass module system features.
Key changes:
- Updated sass-embedded to 1.97.1 across all packages
- Replaced deprecated Sass functions (darken/lighten/adjust-hue) with color.adjust
- Updated color channel access methods to use color.channel
- Separated compound border declarations to avoid deprecation warnings
- Modernized @import to @use/@forward statements
- Updated build tooling (gulp-sass 6.0.1, stylelint 16.22.0)
Reviewed changes
Copilot reviewed 241 out of 242 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updated lockfile with new sass-embedded 1.97.1, stylelint 16.22.0, gulp-sass 6.0.1, and immutable 5.1.3 dependencies |
| packages/devextreme/package.json | Updated gulp-sass to 6.0.1 and sass-embedded to 1.97.1 |
| packages/devextreme/build/gulp/gulp-data-uri.js | Updated Sass function API to handle new sass-embedded argument structure |
| packages/devextreme-themebuilder/package.json | Updated sass-embedded to 1.97.1 and immutable to 5.1.3 |
| packages/devextreme-themebuilder/tests/modules/compiler.test.ts | Updated test assertions for new error structure in sass-embedded |
| packages/devextreme-themebuilder/tests/data/scss/bundles/dx.material.blue.light.scss | Changed @import url() to @import with quoted strings |
| packages/devextreme-themebuilder/src/modules/parse-value.ts | Updated color channel access from direct properties to color.channel() method |
| packages/devextreme-themebuilder/src/modules/bootstrap-extractor.ts | Added deprecation silencing for color-functions, global-builtin, and import |
| packages/devextreme-scss/scss/widgets/material/*.scss | Replaced deprecated darken/lighten/adjust-hue with color.adjust, separated compound border declarations, updated selector-append to selector.append |
| packages/devextreme-scss/scss/widgets/material/color.scss | Added adjust-if-not-achromatic helper function, updated color channel access methods |
| packages/devextreme-scss/scss/widgets/generic/*.scss | Applied same SCSS modernization patterns as material theme |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
VasilyStrelyaev
changed the title
ajivanyandev
previously approved these changes
Jan 5, 2026
EugeniyKiyashko
previously approved these changes
Jan 7, 2026
Tucchhaa
previously approved these changes
Jan 8, 2026
Alyar666
previously approved these changes
Jan 8, 2026
r-farkhutdinov
previously approved these changes
Jan 8, 2026
VasilyStrelyaev
dismissed stale reviews from r-farkhutdinov, Alyar666, Tucchhaa, EugeniyKiyashko, and ajivanyandev
via
275e578
VasilyStrelyaev
force-pushed
the
bump-sass-embedded
branch
from
ec549d7 to
275e578
Compare
r-farkhutdinov
approved these changes
Jan 8, 2026
Alyar666
approved these changes
Jan 8, 2026
ajivanyandev
approved these changes
Jan 8, 2026
Tucchhaa
approved these changes
Jan 8, 2026
EugeniyKiyashko
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.